Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

class名指定時の崩れを修正 #5143

Merged
merged 1 commit into from
Sep 2, 2021

Conversation

matsuoshi
Copy link
Contributor

@matsuoshi matsuoshi commented Sep 2, 2021

概要(Overview・Refs Issue)

issue #5114 / PR #5125 の追加修正です

file_widget にクラス名を指定して呼び出された場合に、ファイルアップロードボタンの表示が崩れる(2つ表示される)問題に対応しました

対象ページ:

  • 管理画面 商品CSV登録
  • 管理画面 カテゴリCSV登録

方針(Policy)

実装に関する補足(Appendix)

テスト(Test)

相談(Discussion)

レビュワー確認項目

  • 動作確認
  • コードレビュー
  • E2E/Unit テスト確認(テストの追加・変更が必要かどうか)
  • 互換性が保持されているか
  • セキュリティ上の問題がないか

@codecov-commenter
Copy link

Codecov Report

Merging #5143 (07528a6) into 4.1 (8a7bf27) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              4.1    #5143      +/-   ##
==========================================
+ Coverage   68.16%   68.17%   +0.01%     
==========================================
  Files         457      455       -2     
  Lines       24988    24930      -58     
==========================================
- Hits        17032    16996      -36     
+ Misses       7956     7934      -22     
Flag Coverage Δ
tests 68.17% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...orage/Handler/SameSiteNoneCompatSessionHandler.php 88.05% <0.00%> (-2.99%) ⬇️
...Controller/Admin/Content/MaintenanceController.php 50.00% <0.00%> (-1.43%) ⬇️
src/Eccube/Repository/ProductRepository.php 96.93% <0.00%> (-0.08%) ⬇️
src/Eccube/Repository/MemberRepository.php 100.00% <0.00%> (ø)
src/Eccube/EventListener/MaintenanceListener.php
...Http/Authentication/EccubeLogoutSuccessHandler.php
...rc/Eccube/EventListener/TwigInitializeListener.php 78.84% <0.00%> (+0.34%) ⬆️
src/Eccube/Service/SystemService.php 44.23% <0.00%> (+1.80%) ⬆️
...be/Service/PurchaseFlow/Processor/TaxProcessor.php 73.77% <0.00%> (+3.27%) ⬆️
src/Eccube/Form/Type/Admin/SearchProductType.php 61.97% <0.00%> (+3.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a7bf27...07528a6. Read the comment docs.

@chihiro-adachi chihiro-adachi added this to the 4.1 milestone Sep 2, 2021
@chihiro-adachi
Copy link
Contributor

@matsuoshi
ありがとうございます。
商品CSVカテゴリCSV共に修正されていることを確認しました。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants