Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump twig/extra-bundle from 3.8.0 to 3.10.0 #6225

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 10, 2024

Bumps twig/extra-bundle from 3.8.0 to 3.10.0.

Commits
  • cdc6e23 Revert "minor #4042 Auto-close PRs on subtree-splits (kbond)"
  • 29cad51 Auto-close PRs on subtree-splits
  • ef6869a change extended DI extension class
  • 3a68ffc fix TwigExtraBundle tests with Symfony 6.0/6.1
  • d131e6d Add a deprecation when a Node uses echo/print
  • 42e4bc7 Fix tests
  • bddb630 Remove support for Twig 2.x and unmaintained Symfony versions
  • See full diff in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [twig/extra-bundle](https://github.com/twigphp/twig-extra-bundle) from 3.8.0 to 3.10.0.
- [Commits](twigphp/twig-extra-bundle@v3.8.0...v3.10.0)

---
updated-dependencies:
- dependency-name: twig/extra-bundle
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file php Pull requests that update Php code labels Jun 10, 2024
@dotani1111 dotani1111 requested a review from nanasess June 10, 2024 05:12
@dotani1111
Copy link
Contributor

@nanasess
composer周りでテストが落ちているようです。
お手隙の際に見てくれたら嬉しいです。

@dotani1111 dotani1111 modified the milestones: 4.3.0, 4.3.x Jun 10, 2024
@nanasess
Copy link
Contributor

@dotani1111 本変更で twig/twig: 3.10.3 を使用するようになったようです。
twig 3.9.0 の変更で、 Twig\Template::display() に型パラメータがついたためにエラーとなっています。
twigphp/Twig@e707774#diff-0a40cf21ba3009b815b6646d4e2d2ad13e93c9603b6ea66919b1994cc828116bR317

Twig\Template::display() をオーバーライドしているプラグインは低そうですが、オーバーライドしている場合は互換性が壊れるので悩みどころですね🤔

@kanako-kina kanako-kina modified the milestones: 4.3.x, 4.x Jun 11, 2024
@ji-eunsoo
Copy link
Contributor

プラグインの互換性がなくなるなどの問題があり、現状、上げることは難しいと思います。
一旦、放置します。

Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 12, 2024

Superseded by #6265.

@dependabot dependabot bot closed this Aug 12, 2024
@dependabot dependabot bot deleted the dependabot/composer/twig/extra-bundle-3.10.0 branch August 12, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants