Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ファイル管理で絶対パスを使用しないよう修正 #462

Merged
merged 7 commits into from
Jun 21, 2021

Conversation

nanasess
Copy link
Contributor

ファイル管理で絶対パスを使用せず、 user_data 以下のみのパスを使用するよう修正

@codecov-commenter
Copy link

codecov-commenter commented May 27, 2021

Codecov Report

Merging #462 (aa795c0) into master (c122ec9) will increase coverage by 0.08%.
The diff coverage is 94.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #462      +/-   ##
==========================================
+ Coverage   53.89%   53.97%   +0.08%     
==========================================
  Files          76       76              
  Lines        8992     9010      +18     
==========================================
+ Hits         4846     4863      +17     
- Misses       4146     4147       +1     
Flag Coverage Δ
tests 53.97% <94.44%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
data/class/helper/SC_Helper_FileManager.php 41.88% <94.44%> (+5.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c122ec9...aa795c0. Read the comment docs.

@nanasess nanasess changed the title [WIP]ファイル管理で絶対パスを使用しないよう修正 ファイル管理で絶対パスを使用しないよう修正 May 27, 2021
@nanasess nanasess marked this pull request as ready for review May 27, 2021 07:11
@nanasess
Copy link
Contributor Author

nanasess commented Jun 2, 2021

ユニットテストのコミット漏れがあったので追加しました

@okazy okazy added this to the 2.17.2 milestone Jun 21, 2021
@okazy okazy merged commit 7384247 into EC-CUBE:master Jun 21, 2021
@okazy
Copy link
Contributor

okazy commented Jun 21, 2021

ありがとうございます。マージしました。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants