Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DateTime型のargsを型変換するように修正 #80

Merged
merged 1 commit into from
Aug 4, 2020

Conversation

kiy0taka
Copy link
Contributor

@kiy0taka kiy0taka commented Aug 4, 2020

  • Plugin\Api\GraphQL\Type\Definition\DateTimeType#parseLiteral で DateTime型を返すように修正。
  • FormTypeを使った場合は、string -> DateTime -> string -> DateTime と2回変換が行われてしまうが、仕方ない。

ref #77

@okazy okazy added the bug Something isn't working label Aug 4, 2020
@okazy okazy added this to the 1.0 milestone Aug 4, 2020
@okazy
Copy link
Contributor

okazy commented Aug 4, 2020

#77 で報告されている内容が解決していることを確認しました。

Copy link
Contributor

@okazy okazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

動作、コード問題ありませんでした。
LeafType の interface に parseLiteral/parseLiteral の説明ちゃんと書かれていましたね...

@okazy
Copy link
Contributor

okazy commented Aug 4, 2020

ありがとうございます。取り込みました。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants