Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

composer/composer 2.1.x でプラグインのアップデートに失敗するのを修正 #19

Merged
merged 2 commits into from
Jul 20, 2021

Conversation

nanasess
Copy link

@nanasess nanasess commented Jul 15, 2021

  • composer2.0 から、 react/promise による非同期処理を使用するようになったが、 eccube-plugin-installer は対応していなかった
  • composer/composer 2.1.x になって、 Composer\Installer\InstallerInterface を実装するメソッド(install/update/uninstall) は PromiseInterface を返さない場合は、各メソッドの処理完了を正常に検知できず、プラグインのアップデートに失敗してしまう
  • PluginInstallerinstall/update/uninstallPromiseInterface を返すよう修正
  • bin/console eccube:composer:remove での依存関係チェックを小文字の name に対応

@nanasess
Copy link
Author

nanasess commented Jul 16, 2021

以下で問題なくプラグインアップデートできることを確認
https://github.com/nanasess/ec-cube/actions/runs/1043483730

@nanasess nanasess marked this pull request as draft July 16, 2021 04:47
@nanasess nanasess marked this pull request as ready for review July 19, 2021 01:56
@nanasess nanasess mentioned this pull request Jul 19, 2021
11 tasks
Copy link

@okazy okazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

差分確認OK

@okazy okazy added this to the 2.0 milestone Jul 20, 2021
@okazy okazy merged commit b5e17c3 into EC-CUBE:2.0 Jul 20, 2021
@okazy
Copy link

okazy commented Jul 20, 2021

ありがとうございます。取り込みました。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants