Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pisces variables case to preferences file #486

Closed
treerink opened this issue Jun 12, 2019 · 3 comments
Closed

Add pisces variables case to preferences file #486

treerink opened this issue Jun 12, 2019 · 3 comments
Assignees
Labels
release 1.0.x A few fixes, depending on PCMDI, belonging to release 1.0 will be solved in a minor sub post release

Comments

@treerink
Copy link
Collaborator

Related to point 4 in the list in #435, it appears that after solving tos from this list in #477, the rest of the skipped variables in a new latest cmorisation test with the cmip6-output-control-files/test-all-nemo-mip-variables/ are all PISCES variables. That means that the skipping is correct with the used AOGCM version, but best would be to add these PISCES variables to the preferences file prefs.py.

Note however that the latest NMEO skipped list differs from the reported list under point 4 in the list in #435, probably because an alder ece2cmor version was used (?).

The following NEMO-PISCES skipped list comes from a latest test with the cmip6-output-control-files/test-all-nemo-mip-variables/ xml file_def files and the latest ece2cmor3 version:

dissicos 	 Omon      pisces variable 
talkos 		 Omon      pisces variable 
phos 		 Omon      pisces variable 
o2os 		 Omon      pisces variable 
no3os 		 Omon      pisces variable 
po4os 		 Omon      pisces variable 
chlos 		 Omon      pisces variable*
intpp 		 Omon      pisces variable 
epc100 		 Omon      pisces variable 
epsi100 	 Omon      pisces variable 
epcalc100 	 Omon      pisces variable 
spco2 		 Omon      pisces variable 
dpco2 		 Omon      pisces variable 
fgco2 		 Omon      pisces variable*
fgo2 		 Omon      pisces variable 
froc 		 Omon      pisces variable 
o2min 		 Omon      pisces variable 
talk 		 Omon      pisces variable*
o2 		 Omon      pisces variable*
chl 		 Omon      pisces variable*
dissic 		 Oyr    1  pisces variable 
talk 		 Oyr    2  pisces variable*
ph 		 Oyr    1  pisces variable 
o2 		 Oyr    2  pisces variable*
no3 		 Oyr    1  pisces variable 
po4 		 Oyr    1  pisces variable*
dfe 		 Oyr    1  pisces variable*
si 		 Oyr    1  pisces variable*
chl 		 Oyr    2  pisces variable*
fgco2 		 Oyr    2  pisces variable*

I checked one by one that these fields are PISCES fields, so they can be added to the preferences file for EC-Earth3 configurations which include PISCES.

@treerink treerink added the release 1.0.x A few fixes, depending on PCMDI, belonging to release 1.0 will be solved in a minor sub post release label Jun 12, 2019
@treerink treerink self-assigned this Jun 12, 2019
treerink added a commit that referenced this issue Jun 12, 2019
treerink added a commit that referenced this issue Jun 12, 2019
…this varlist is based on a AOGCM request (could be changed to an EC-Earth3-CC request) #486.
treerink added a commit that referenced this issue Jun 12, 2019
… on the EC-Earth3-CC request (its a choice), so it includes all NEMO variables #486.
@treerink
Copy link
Collaborator Author

Done

@treerink
Copy link
Collaborator Author

I missed a lot of other pisces variables (ones which e.g. were listed under point 5 in #435, I only included the ones under point 4). All pisces variables need to be included in the prefs.py.

@treerink
Copy link
Collaborator Author

Issue is solved now, no skipped PISCES variables pop up any longer in the NEMO cmorisation log with the AOGCM version in the cmorisation of the historical results.

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release 1.0.x A few fixes, depending on PCMDI, belonging to release 1.0 will be solved in a minor sub post release
Projects
None yet
Development

No branches or pull requests

1 participant