Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Added my name Marco to .zenodo.json #5150

Closed
wants to merge 1 commit into from
Closed

[WIP] Added my name Marco to .zenodo.json #5150

wants to merge 1 commit into from

Conversation

marcoacc95
Copy link
Contributor

@marcoacc95 marcoacc95 commented Aug 16, 2024 •
edited by ax3l
Loading

  • merge with or after QDSMC fluid model addition 🚀 ✨

@ax3l
Copy link
Member

ax3l commented Aug 16, 2024

Hi @marcoacc95,

Thank you for your first pull request to WarpX and welcome! 🎉

The .zenodo.json file tracks developers of WarpX that have contributed major features to the code base. I hope I am not overlooking something you contributed, but if you are ok, I would wait to add your name until your first major features are reviewed and merged? :)

Thank you for your understanding and please let us know if we missed something.

@ax3l ax3l added the component: documentation Docs, readme and manual label Aug 16, 2024
ax3l
ax3l requested changes Aug 16, 2024
View reviewed changes
Copy link
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comment above :)

@ax3l ax3l changed the title Added my name Marco to .zenodo.json [WIP] Added my name Marco to .zenodo.json Aug 16, 2024
@ax3l
Copy link
Member

ax3l commented Aug 16, 2024

Clarified with @clarkse - we simply keep this PR open until your QDSMC fluid model is added 🤩

We look forward to meeting you at the hackathon @marcoacc95 🎉
Welcome again to WarpX, we can't wait to work with you ✨

@ax3l ax3l marked this pull request as draft August 16, 2024 18:45
@marcoacc95 marcoacc95 closed this Sep 24, 2024
@marcoacc95 marcoacc95 deleted the add_zenodo branch September 24, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ax3l ax3l ax3l requested changes

@roelof-groenewald roelof-groenewald Awaiting requested review from roelof-groenewald

Assignees
No one assigned
Labels
component: documentation Docs, readme and manual
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcoacc95 @ax3l