New bot command bot: status
#237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 25, 2024 12:29
trz42
requested changes
Jan 25, 2024
|
|
||
|
|
||
| def request_bot_build_issue_comments(repo_name, pr_number): | ||
| status_table = {'arch': [], 'date': [], 'status': [], 'url': [], 'result': []} |
There was a problem hiding this comment.
Wonder a bit if it would be better to let status_table be a list of dictionaries instead of a dictionary of lists where we assume that lists are always identically formed (same length, elements at same index belong to each other).
There was a problem hiding this comment.
I'm open to that. Because it actually takes some effort to put it in a dictionary with lists.
There was a problem hiding this comment.
Ack. We can think about that later in case it becomes necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command creates a comment that contains a table with all the builds done in the pr where the command is called.
example: