Licenses for EESSI #457
Open
Licenses for EESSI #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Instance
|
|
Now the add_license_info.py script can process pypi, github and manual license addition to licenses.json file. There is also included work for other license fonts (libraries.io, repology and CRAN). This is fully functional, ready for review. |
Updates by the bot instance
|
|
Waiting for review/approval |
Updates by the bot instance
|
As suggested in 02/04/2023 meeting. Previously, spdx argument has been used to manually feeded licenses.
ocaisa
requested changes
May 2, 2024
| print('project in licenses.json') | ||
| else: | ||
| print('we do not have the license, adding into licenses.json') | ||
| licenses[project]=dict(info) |
There was a problem hiding this comment.
From what I can see, this doesn't store information for the case of a licence change or multiple licences (academic versus commercial).
| else: | ||
| print('we do not have the license, adding into licenses.json') | ||
| licenses[project]=dict(info) | ||
| licJson=json.dumps(licenses, indent=4) |
There was a problem hiding this comment.
Perhaps we should give 2 options here. There's kind of an assumption that this will make a change but if this is called within a GitHub Action the update to the licences file will be lost (without giving the Action permissions to write to the PR). It would be good to allow the display of the information in patch format so that it can be copied from the GitHub Actions and applied (or even posted as a review).
This was referenced Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP