Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove JADEForwardPass and _TerminateOnCycle and update to SDDP v0.4.8 #27

Merged
merged 2 commits into from
Dec 19, 2022

Conversation

odow
Copy link
Collaborator

@odow odow commented Dec 19, 2022

Won't pass tests until SDDP v0.4.8 is released.

Closes #19

@odow odow mentioned this pull request Dec 19, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #27 (f8bb244) into develop (c4621f9) will decrease coverage by 0.57%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop      #27      +/-   ##
===========================================
- Coverage    62.77%   62.20%   -0.58%     
===========================================
  Files           19       19              
  Lines         2243     2209      -34     
===========================================
- Hits          1408     1374      -34     
  Misses         835      835              
Impacted Files Coverage Δ
src/sddp_modifications.jl 0.00% <ø> (-33.67%) ⬇️
src/solve.jl 61.53% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@odow odow merged commit 59b29e3 into develop Dec 19, 2022
@odow odow deleted the od/sddp-v0.4.8 branch December 19, 2022 20:17
@odow odow mentioned this pull request Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants