[Bug Fix] Client not updating HP bar when an HP Buff with a Heal is applied. #4237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug: When an HP buff with a heal effect is applied for first time, the heal portion of the effect heals the client and updates HPs currently server side, but client side the HP bar does not register it as a heal thus you display as less than full HP. However due to server thinking your healed, you are unable to correct it by healing. Solution: You need to resend the HP update after buff completed and action packet resent.
would result in same bug
|
This seems to be in #4238 as well. |
Kinglykrab
approved these changes
Apr 1, 2024
Akkadius
approved these changes
Apr 2, 2024
MortimerGreenwald
pushed a commit
to MortimerGreenwald/Server
that referenced
this pull request
Apr 15, 2024
…pplied. (EQEmu#4237) * [Bug Fix] HP Bar not updating when applying HP Buff with a heal. Bug: When an HP buff with a heal effect is applied for first time, the heal portion of the effect heals the client and updates HPs currently server side, but client side the HP bar does not register it as a heal thus you display as less than full HP. However due to server thinking your healed, you are unable to correct it by healing. Solution: You need to resend the HP update after buff completed and action packet resent. * add SE_MaxHPChange to fix would result in same bug
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Came across this bug while trying to fix another bug...
Bug: When an HP buff with a heal effect is applied for first time (example Virtue), the heal portion of the effect heals the client and updates HPs correctly server side, but client side the HP bar does not register it as a heal thus you display as less than full HP. However, due to server thinking your healed, you are unable to correct it by healing yourself.
Solution: We need to resend the HP update again after buff completed and action packet resent.
This is currently coded to apply to spell effects SPA 69 (Total HP) and SPA 214 (Max HP Change) that have instant healing components SPA 0 or SPA 79. Possible that this may need to be expanded on in the future.