[Messages] Fix bug where DoT messages stop coming out when mob dies. #4249
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
My old PR #2289 accidentally removed messages for DoTs that are cast by NPCs on PCs after the NPC dies.
On live:
We now match this.
Additionally I created an issue #4248 because its always been true on live that DoTs live past the corpse. That change on eqemu is larger in scale and I think should be separate from this PR. On live, the damage still occurs and looks like this:
Type of change
Please delete options that are not relevant.
Testing
Killed a mob after getting DoTTed and made sure damage was getting done and we got the messages again.
Clients tested: RoF2
Checklist