Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Fix] Fix EVENT_USE_SKILL with Sense Heading #4424

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

Kinglykrab
Copy link
Contributor

@Kinglykrab Kinglykrab commented Jul 22, 2024

Description

  • Resolves an issue described in Sense Heading does not trigger EVENT_USE_SKILL #4250 where when Skills:TrainSenseHeading is set to false we do not parse the use of the skill at all, this simply sends us to the handler method regardless of the status of the rule and handles the rule's logic within the method itself. This allows us to parse the use of the skill for servers who do not want to enable the rule to use EVENT_USE_SKILL with Sense Heading.

Type of change

  • Bug fix

Testing

image

Checklist

  • I have tested my changes
  • I have performed a self-review of my code. Ensuring variables, functions and methods are named in a human-readable way, comments are added only where naming of variables, functions and methods can't give enough context.
  • I own the changes of my code and take responsibility for the potential issues that occur

@Akkadius Akkadius merged commit 29fdf7e into master Jul 23, 2024
2 checks passed
@Akkadius Akkadius deleted the bug_fix/sense_heading_event_use_skill branch July 23, 2024 01:45
@joligario joligario mentioned this pull request Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants