Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Performance] Move Discipline Loading to Client::CompleteConnect() #4466

Merged
merged 3 commits into from
Sep 9, 2024
Merged

[Performance] Move Discipline Loading to Client::CompleteConnect() #4466

merged 3 commits into from
Sep 9, 2024

Conversation

Kinglykrab
Copy link
Contributor

@Kinglykrab Kinglykrab commented Aug 30, 2024 •
edited
Loading

Description

  • This moves discipline loading to Client::CompleteConnect() to remove some of the data loaded in Handle_OP_ZoneEntry.
  • The idea here is reducing the amount of data loading mid-zoning will reduce the amount of crashes we will see on zoning.

Type of change

  • New feature

Testing

Screencast.from.09-09-2024.07.17.40.PM.webm

Checklist

  • I have tested my changes
  • I have performed a self-review of my code. Ensuring variables, functions and methods are named in a human-readable way, comments are added only where naming of variables, functions and methods can't give enough context.
  • I own the changes of my code and take responsibility for the potential issues that occur

@Kinglykrab Kinglykrab marked this pull request as draft August 30, 2024 16:39
@Kinglykrab Kinglykrab marked this pull request as ready for review August 30, 2024 16:50
@MortimerGreenwald
Copy link
Contributor

awesome! any help with crashes while zoning is much appreciated.

Akkadius
Akkadius approved these changes Sep 8, 2024
View reviewed changes
Copy link
Member

@Akkadius Akkadius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, this one seems straightforward but would be good to have attached testing

@Akkadius Akkadius merged commit 40fecbf into master Sep 9, 2024
2 checks passed
@Akkadius Akkadius deleted the performance/character_discipline_loading branch September 9, 2024 23:20
Kinglykrab added a commit that referenced this pull request Sep 13, 2024
@Kinglykrab
[Release] 22.55.2
2a361b6 
### Code

* Add IsCloseToBanker method ([#4462](#4462)) @Akkadius 2024-08-27

### Feature

* Add Rule to Limit Task Update Messages ([#4459](#4459)) @Kinglykrab 2024-08-28
* Allow NPCs to cast Sacrifice ([#4470](#4470)) @fuzzlecutter 2024-09-12
* Lazy Load Bank Contents ([#4453](#4453)) @catapultam-habeo 2024-08-27

### Fixes

* Add RULE_STRING to RuleManager::ResetRules ([#4467](#4467)) @Kinglykrab 2024-09-07
* Fix Bard Effect in Migration 9237 ([#4468](#4468)) @Kinglykrab 2024-09-09
* ModernAAScalingEnabled() Calculation Error ([#4469](#4469)) @carolus21rex 2024-09-11

### Performance

* Move Discipline Loading to Client::CompleteConnect() ([#4466](#4466)) @Kinglykrab 2024-09-09

### Rules

* Add a Bandolier Swap Delay Rule ([#4465](#4465)) @Kinglykrab 2024-09-08
@Kinglykrab Kinglykrab mentioned this pull request Sep 13, 2024
Merged
Akkadius pushed a commit that referenced this pull request Sep 13, 2024
@Kinglykrab
[Release] 22.56.0 (#4471)
a7550fb 
* [Release] 22.55.2

### Code

* Add IsCloseToBanker method ([#4462](#4462)) @Akkadius 2024-08-27

### Feature

* Add Rule to Limit Task Update Messages ([#4459](#4459)) @Kinglykrab 2024-08-28
* Allow NPCs to cast Sacrifice ([#4470](#4470)) @fuzzlecutter 2024-09-12
* Lazy Load Bank Contents ([#4453](#4453)) @catapultam-habeo 2024-08-27

### Fixes

* Add RULE_STRING to RuleManager::ResetRules ([#4467](#4467)) @Kinglykrab 2024-09-07
* Fix Bard Effect in Migration 9237 ([#4468](#4468)) @Kinglykrab 2024-09-09
* ModernAAScalingEnabled() Calculation Error ([#4469](#4469)) @carolus21rex 2024-09-11

### Performance

* Move Discipline Loading to Client::CompleteConnect() ([#4466](#4466)) @Kinglykrab 2024-09-09

### Rules

* Add a Bandolier Swap Delay Rule ([#4465](#4465)) @Kinglykrab 2024-09-08

* 22.56.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akkadius Akkadius Akkadius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kinglykrab @MortimerGreenwald @Akkadius