Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Fix] Fix Untrained Disciplines in Client::SaveDisciplines() #4472

Merged
merged 5 commits into from
Sep 20, 2024
Merged

[Bug Fix] Fix Untrained Disciplines in Client::SaveDisciplines() #4472

merged 5 commits into from
Sep 20, 2024

Conversation

Kinglykrab
Copy link
Contributor

Description

  • Fixes an issue introduced in [Spells/Disciplines] Bulk Train / Scribe #1640 where we are not actually deleting untrained disciplines and only replacing those that have been added/changed.
  • Untraining player disciplines using the bulk methods was removing the disciplines visually, but leaving behind the database rows. This caused players' disciplines to reappear on zoning.

Type of change

  • Bug fix

Testing

Before using #untraindiscs

image
image

After using #untraindiscs

image
image

Checklist

  • I have tested my changes
  • I have performed a self-review of my code. Ensuring variables, functions and methods are named in a human-readable way, comments are added only where naming of variables, functions and methods can't give enough context.
  • I own the changes of my code and take responsibility for the potential issues that occur

@Akkadius Akkadius merged commit 1af2524 into master Sep 20, 2024
2 checks passed
@Akkadius Akkadius deleted the bug_fix/client_savedisciplines branch September 20, 2024 02:09
catapultam-habeo pushed a commit to The-Heroes-Journey-EQEMU/Server that referenced this pull request Oct 6, 2024
@Kinglykrab @oddx2k @catapultam-habeo
[Bug Fix] Fix Untrained Disciplines in Client::SaveDisciplines() (EQE…
77de8ce 
…mu#4472)

* [Bug Fix] Fix Untrained Disciplines in Client::SaveDisciplines()

* [Bug Fix] Fix Infinite Loop in Adventure::Finished() (EQEmu#4473)

Fix infinite loop condition when bot encountered

* [Bug Fix] Fix Untrained Disciplines in Client::SaveDisciplines()

* Change to release

---------

Co-authored-by: oddx2k <[email protected]>
catapultam-habeo pushed a commit to The-Heroes-Journey-EQEMU/Server that referenced this pull request Oct 6, 2024
@Kinglykrab @oddx2k @catapultam-habeo
[Bug Fix] Fix Untrained Disciplines in Client::SaveDisciplines() (EQE…
b5e7085 
…mu#4472)

* [Bug Fix] Fix Untrained Disciplines in Client::SaveDisciplines()

* [Bug Fix] Fix Infinite Loop in Adventure::Finished() (EQEmu#4473)

Fix infinite loop condition when bot encountered

* [Bug Fix] Fix Untrained Disciplines in Client::SaveDisciplines()

* Change to release

---------

Co-authored-by: oddx2k <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akkadius Akkadius Akkadius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kinglykrab @Akkadius @oddx2k