Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Fix] Fix Issue with Database::ReserveName #4477

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

Kinglykrab
Copy link
Contributor

Description

  • If a bot or NPC is created prior to a character being created, they may end up with the same name.
  • This causes issues when a bot is spawned because it will crash any player with that same name in the zone.
  • NPCs with the same name will get the 000 identifier instead of the player, which could cause issues.

Type of change

  • Bug fix

Checklist

  • I have tested my changes
  • I have performed a self-review of my code. Ensuring variables, functions and methods are named in a human-readable way, comments are added only where naming of variables, functions and methods can't give enough context.
  • I own the changes of my code and take responsibility for the potential issues that occur

@Akkadius Akkadius merged commit c3e1c53 into master Sep 20, 2024
2 checks passed
@Akkadius Akkadius deleted the bug_fix/database_reservename branch September 20, 2024 02:15
@Kinglykrab Kinglykrab mentioned this pull request Sep 20, 2024
catapultam-habeo pushed a commit to The-Heroes-Journey-EQEMU/Server that referenced this pull request Oct 6, 2024
catapultam-habeo pushed a commit to The-Heroes-Journey-EQEMU/Server that referenced this pull request Oct 6, 2024
@catapultam-habeo
Copy link
Contributor

This PR fails to check content database in a multi-tenant deployment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants