[Bug Fix] fixed a bug where it would use npc value instead of faction value in the database. #4491
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed the faction value used in QuestReward boolean function.
Fixes # (issue)
This part of the code was changed when it was removed from shared memory to use repository. The way the code was written before, it was using the variable npc_value to passed on the database called to parameter of value. It was changed to use the variable instead of the actual database call value. This PR corrected this.
note This isn't used in any of the QuestReward scripts that is currently in the git peqquest repository. I scripted this myself to test this.
Type of change
corrections.
Please delete options that are not relevant.
Testing
npc_value before the fix was 0 therefore it would just passed over since it uses > 0 or < 0. and it would just use whatever the value is currently on the list.
script using Niola_Impholder bat quest:
Before the fix:
After the fix:
Clients tested:
RoF2
Checklist