Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Fix] fixed a bug where it would use npc value instead of faction value in the database. #4491

Merged
merged 2 commits into from
Sep 29, 2024

Conversation

regneq
Copy link
Contributor

@regneq regneq commented Sep 29, 2024

Description

Fixed the faction value used in QuestReward boolean function.

Fixes # (issue)
This part of the code was changed when it was removed from shared memory to use repository. The way the code was written before, it was using the variable npc_value to passed on the database called to parameter of value. It was changed to use the variable instead of the actual database call value. This PR corrected this.

note This isn't used in any of the QuestReward scripts that is currently in the git peqquest repository. I scripted this myself to test this.

Type of change

corrections.

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Testing

npc_value before the fix was 0 therefore it would just passed over since it uses > 0 or < 0. and it would just use whatever the value is currently on the list.

script using Niola_Impholder bat quest:
image

Before the fix:
before

After the fix:
after

Clients tested:
RoF2

Checklist

  • I have tested my changes
  • I have performed a self-review of my code. Ensuring variables, functions and methods are named in a human-readable way, comments are added only where naming of variables, functions and methods can't give enough context.
  • I have made corresponding changes to the documentation (if applicable, if not delete this line)
  • I own the changes of my code and take responsibility for the potential issues that occur

@Kinglykrab Kinglykrab merged commit 8d23e71 into EQEmu:master Sep 29, 2024
1 check passed
catapultam-habeo pushed a commit to The-Heroes-Journey-EQEMU/Server that referenced this pull request Oct 6, 2024
catapultam-habeo pushed a commit to The-Heroes-Journey-EQEMU/Server that referenced this pull request Oct 6, 2024
@Akkadius Akkadius mentioned this pull request Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants