Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Crash] Fixes a crash when the faction_list db table is empty. #4511

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

KimLS
Copy link
Member

@KimLS KimLS commented Oct 13, 2024

Description

If you have no data in the faction_list table then zone server will crash on startup because the query for max # of rows returns null instead of zero when there's no entries in the table.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Testing

I've tested before and after the change. It no longer crashes.

Clients tested:

Checklist

  • I have tested my changes
  • I have performed a self-review of my code. Ensuring variables, functions and methods are named in a human-readable way, comments are added only where naming of variables, functions and methods can't give enough context.
  • I own the changes of my code and take responsibility for the potential issues that occur

@Akkadius Akkadius changed the title Fixes a crash when the faction_list db table is empty. [Crash] Fixes a crash when the faction_list db table is empty. Oct 14, 2024
@Akkadius Akkadius merged commit ae198ae into master Oct 14, 2024
2 checks passed
@Akkadius Akkadius deleted the crash_when_faction_tables_empty branch October 14, 2024 01:50
@Akkadius Akkadius mentioned this pull request Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants