Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements related to multidimNcFiles #169

Merged
merged 9 commits into from
Jul 11, 2024

Conversation

ChrisJohnNOAA
Copy link
Contributor

Description

Actually use the removeMVRows dataset parameter now (which allows turning off the related logic). This can provide a significant performance increase.

Also refactor the general processing while loading files including performance improvements.

Fixes #152

Type of change

Please delete options that are not relevant.

  • [ X ] Bug fix (non-breaking change which fixes an issue)
  • [ X ] New feature (non-breaking change which adds functionality)
  • [ X ] This change requires a documentation update

Checklist before requesting a review

  • [ X ] I have performed a self-review of my code
  • [ X ] My code follows the style guidelines of this project
  • [ X ] I have commented my code, particularly in hard-to-understand areas
  • [ X ] I have made corresponding changes to the documentation
  • [ X ] My changes generate no new warnings
  • [ X ] I have added tests that prove my fix is effective or that my feature works
  • [ X ] New and existing unit tests pass locally with my changes

Specifically requests with no data in the source files (only globals, jexl script, or variables) will now function.
This is used in readMultidimNc and if set to false (defaults to true, so prior to this change was always true), could provide significant speed up to queries for some EDDTableFromMultidimNcFiles datasets.
This includes updates like loading and using constraints before loading the remaining variables. In the test queries, the new code is faster, but the improvement is small compared to setting removeMVRows to false.
@ChrisJohnNOAA ChrisJohnNOAA merged commit 0e5889b into ERDDAP:main Jul 11, 2024
@ChrisJohnNOAA ChrisJohnNOAA deleted the multidimNcFiles branch July 22, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strange case where querying a dataset retrun erroneous 404 No Rows result
1 participant