Add test datasets using Zarr files #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve file path handling to make it easier to run dasdds and generatedatasetsxml during development. Also fix some atomicInteger interactions that were not properly migrated. Plan to add tests using these datasets before merge.
…ew zarr datasets.
Some people store them as zipped zarr files (the same folder but zipped). Not sure if we want to support that in ERDDAP. |
I'm looking into this. There are additional changes needed to support zipped zarr files. |
I added zipped zarr support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds test datasets based on Zarr files and tests to verify behavior.
Because zarr "files" are different (they're folders), there is some subtle behavior differences needed to make them work in ERDDAP. This approach requires datasets to include "zarr" in the filename or path regex for the dataset to trigger the behavior differences. It might be simpler for users (though likely much more code and/or more complicated changes) to have a new dataset type(s) that are specific to zarr files.
Type of change
Please delete options that are not relevant.
Checklist before requesting a review
There are new (log) warnings generated when loading the example zarr datasets.