Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sax parser enable for tests #190

Merged
merged 12 commits into from
Aug 22, 2024
Merged

Sax parser enable for tests #190

merged 12 commits into from
Aug 22, 2024

Conversation

ChrisJohnNOAA
Copy link
Contributor

Description

This enables the new SAX parser in tests and fixes tests to work with it.

Type of change

Please delete options that are not relevant.

  • [ X ] New feature (non-breaking change which adds functionality)

Checklist before requesting a review

  • [ X ] I have performed a self-review of my code
  • [ X ] My code follows the style guidelines of this project
  • [ X ] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [ X ] My changes generate no new warnings
  • [ X ] I have added tests that prove my fix is effective or that my feature works
  • [ X ] New and existing unit tests pass locally with my changes

ayushsingh01042003 and others added 12 commits August 15, 2024 21:07
@ayushsingh01042003
EDDGridFromEtopoHandler bug fix
3873614
@ayushsingh01042003
Handler Factory fix
2f61307
@ChrisJohnNOAA
Make changes to EDDTestDatasets to improve compatibility with SAXPars…
2de2b50 
…er. Also improve error handling when dataset creation fails with the SAXParser.
@ayushsingh01042003
Merge pull request #1 from ERDDAP/sax_parser_changes
4972404 
Make changes to EDDTestDatasets to improve compatibility with SAXParser
@ayushsingh01042003
datasetsThatFailedToLoad for Sax Parser
244d0eb
@ChrisJohnNOAA
Add support for using the new sax parser with EDD.oneFromXml, EDD.one…
7c0f5f2 
…FromXmlFragment, and EDD.oneFromDatasetsXml.
@ayushsingh01042003
Merge pull request #2 from ERDDAP/sax_parser_changes
353dee3 
Add support for using the new sax parser with EDD.oneFromXml, EDD.oneFromXmlFragment, and EDD.oneFromDatasetsXml.
@ayushsingh01042003
Bug Fix: datasetID's for failed datasets
617b201
@ayushsingh01042003
Failed datasets messages for sax and simpleXml parser on status page
dd92d39
@ChrisJohnNOAA
Update tests and data to have tests pass with both XML parsers (new S…
70d79cc 
…AX parser and old SimpleXml).
@ChrisJohnNOAA
Merge branch 'SAXParser' of https://github.com/ayushsingh01042003/erddap
1c163dd 
 into sax_parser_changes
@ayushsingh01042003
Merge pull request #3 from ERDDAP/sax_parser_changes
b61682a 
Sax parser changes
@ChrisJohnNOAA ChrisJohnNOAA merged commit 23883f4 into ERDDAP:main Aug 22, 2024
@ayushsingh01042003
Copy link
Contributor

The final GSoC 2024 tag!

@ayushsingh01042003 ayushsingh01042003 deleted the SAXParser branch August 22, 2024 17:46
@mwengren
Copy link
Contributor

Congrats @ayushsingh01042003 on completing your project!

Please also add a label so we can track this contribution for our end of program tally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayushsingh01042003 ayushsingh01042003 ayushsingh01042003 approved these changes

Assignees
No one assigned
Labels
GSoC-2024
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChrisJohnNOAA @ayushsingh01042003 @mwengren