Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate slow and integration tests out to be run with fail safe #195

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

ChrisJohnNOAA
Copy link
Contributor

Description

Separate slow and integration tests out to be run with maven fail safe plugin. This allows the main unit test suite to complete much faster (while still covering most of the code).

Also adds a retry with backoff to testForBrokenLinks to make it more reliable.

Type of change

Please delete options that are not relevant.

  • [ X ] Bug fix (non-breaking change which fixes an issue)

Checklist before requesting a review

  • [ X ] I have performed a self-review of my code
  • [ X ] My code follows the style guidelines of this project
  • [ X ] I have commented my code, particularly in hard-to-understand areas
  • [ X ] I have made corresponding changes to the documentation
  • [ X ] My changes generate no new warnings
  • [ X ] I have added tests that prove my fix is effective or that my feature works
  • [ X ] New and existing unit tests pass locally with my changes

…e plugin. This allows the main unit test suite to complete much faster (while still covering most of the code).

Also adds a retry with backoff to testForBrokenLinks to make it more reliable.
@ChrisJohnNOAA ChrisJohnNOAA merged commit 78284e5 into ERDDAP:main Sep 3, 2024
@srstsavage
Copy link
Contributor

Surefire tests all pass in about 20 minutes on my test Linux machine. This is great!

[INFO] Results:
[INFO] 
[WARNING] Tests run: 347, Failures: 0, Errors: 0, Skipped: 1
[INFO] 
[INFO] 
[INFO] --- jacoco:0.8.12:report (generate-code-coverage-report) @ ERDDAP ---
[INFO] Loading execution data file /home/shane/src/erddap/target/jacoco.exec
[INFO] Analyzed bundle 'erddap' with 475 classes
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  21:32 min
[INFO] Finished at: 2024-09-03T10:30:28-07:00
[INFO] ------------------------------------------------------------------------

@ChrisJohnNOAA ChrisJohnNOAA deleted the test_updates branch September 30, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants