Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have the parquet export transform from fill values to mising values #226

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

ChrisJohnNOAA
Copy link
Contributor

Description

Have the parquet export transform from fill values to mising values like other dataset exports

Have PAOne properly set missing value based on the original PA.

Fixes # Parquet files write out fill values instead of converting to no data.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist before requesting a review

  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

…like other dataset exports).

Have PAOne properly set missing value based on the original PA.
…ome edge cases where toCSVString ends up providing empty string.
@ChrisJohnNOAA ChrisJohnNOAA merged commit 1ef0d53 into ERDDAP:main Nov 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant