Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional tiled history files for ATM #257

Merged
merged 4 commits into from
Nov 23, 2021

Conversation

DeniseWorthen
Copy link
Collaborator

@DeniseWorthen DeniseWorthen commented Nov 18, 2021

Description of changes

Allows the inst and avg history files for the ATM to be written on the cubed sphere tiles instead of the mesh by setting the configuration variable history_tile_atm = cubed sphere tile size (e.g. 96,192,384).

Specific notes

Contributors other than yourself, if any:

CMEPS Issues Fixed (include github issue #): NOAA-EMC/CMEPS #59

Are changes expected to change answers?

  • bit for bit
  • different at roundoff level
  • more substantial

Any User Interface Changes (namelist or namelist defaults changes)?

  • Yes
  • No. History files for the ATM will be written on the mesh unless tiled history is requested via namelist configuration.

Testing performed if application target is CESM:(either UFS-S2S or CESM testing is required):
verified that ERS_Ld7.f19_g17.B1850.cheyenne_intel.allactive-defaultio was bfb with cesm2_3_alpha07b

Testing performed if application target is UFS-coupled:

  • (recommended) UFS-coupled testing
    • description: Tested ufs-weather-model develop branch against a CMEPS feature branch containing these changes. Both inst and avg history files were written for atm, ice and ocn. The files for ice and ocn were compared directly using cprnc and all were B4B. For the atm history files, the history files containing the mesh were post-processed with NCL to write the fields on the individual tiles. Multiple fields at multiple timesteps were checked against the tiled history file output and all were identical.
    • details (e.g. failed tests):

Testing performed if application target is UFS-HAFS:

  • (recommended) UFS-HAFS testing
    • description:
    • details (e.g. failed tests):

Hashes used for testing:

DeniseWorthen and others added 2 commits November 18, 2021 10:15
* for inst and avg atm history files, allow the fields
to be written on cubed sphere tiles instead of mesh
* revert two unintended changes
@jedwards4b
Copy link
Collaborator

@DeniseWorthen To be clear I think that this is specific to the fv3 cubed sphere data structure and won't work for other cubed sphere structures.

@DeniseWorthen
Copy link
Collaborator Author

I decided to test in GNU+debug mode and got a seg fault when the restart was being written.

95:#1  0x6a032ba in __med_io_mod_MOD_med_io_write_fb
95:     at /glade/work/worthen/ufs_testcmepsPRs/CMEPS-interface/CMEPS/mediator/med_io_mod.F90:839

I'll need to track that down.

@mvertens mvertens merged commit f6409c4 into ESCOMP:master Nov 23, 2021
DeniseWorthen added a commit to NOAA-EMC/CMEPS that referenced this pull request Dec 16, 2021
* moved files into ufs
* implemented different interface for ufs flux_atmocn_mod
* add compile fixes for ufs
* removed reference to util and replaced with ufs
* clean up of Makefile
* removed references to use of med_kind_mod and introduced ufs_kind_mod
* removed unneeded files needed by ufs
* Optional tiled history files for ATM (ESCOMP#257)
@DeniseWorthen DeniseWorthen deleted the feature/optional_tiled_atmhist branch January 10, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants