-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement GitHub Actions CI testing (Fixes #138) #189
Implement GitHub Actions CI testing (Fixes #138) #189
Conversation
Create the workflow! 1. Start with the simplest workflow item in this issue: Running the check_default_parameters test.
Silly Mistake. This is for the running of check_default_parameters.py
Remove pyyaml install because already installed, adjust file name
Move checkout from default_params_job to separate job (simple_checkout) and list as a "need" on the check_default_params and black_check.. job
Added: 1. Build Job: Checkout CESM, Load Externals (Including MOM6) 2. Test_lightweight_standalone_mom Job: Run MOM6 on some sample test cases
Copied from NCAR/MOM6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @manishvenu! This is awesome, and a much-needed enhancement.
I have a suggestion: Since the workflow is set up to run on Ubuntu, it might be more consistent to use an Ubuntu-specific script rather than the Darwin build script. Here's what I suggest:
(1) Consider creating an ubuntu-gnu.mk
template under the standalone/templates
directory, perhaps using the homebrew-gnu.mk
as a reference.
(2) Instead of having separate build scripts for each machine/compiler configuration, how about creating a single build_examples.sh
script with --machine and --compiler arguments? You can take a look at the approach I used in my pull request #186, where I added one of those arguments.
…ld' into 138-set-up-github-actions-ci-testing This merges the changes from Alper's start at adding command line args to the build_examples scripts as a starting point for this work
Notes/Qs in changes resulting from @alperaltuntas review:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks.
This PR fixes Issue #138, which was about implementing CI in MOM_Interface with four initial tasks. Please reference back to the issue for those requirements.
Changes Introduced by this PR:
CI/Github Action Workflow Details:
Workflow is structured into three independent jobs that are triggered on push and pull-request events onto the
main
branch:cime_config
check_default_params
test under thetests
folderTesting:
Test CI
), and the first job with Black formatting was already failing (commit) and was corrected early on in the process.Notes:
actions/checkout@v4
(See the stepsCheckout initial event (Pull Request)
andCheckout initial event (Push)
).Thanks,
Manish V.
Fixes #138