Fix svn on Windows #167
Merged
Fix svn on Windows #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves ESMCI#166
From some testing, I don't think it's essential that we avoid a double slash, but this is needed for unit tests to pass, and leads to cleaner URLs.
Now both branches of the self._url.endswith conditional block from the last commit are covered: test_check_url_same now covers the branch where the URL does *not* already end with '/', and test_repo_dir_synced appears to still cover the branch where the URL *does* already end with '/' (based on seeing that that unit test still fails if that branch is wrong).
|
I don't have a Windows machine to test on, but I can see how this code would cause problems on Windows before this change. @fischer-ncar do you have a Windows machine to test this on? If not, we could enlist someone (maybe Cheryl?) to test this on Windows, or just bring it in figuring that this at least is an improvement over the previous state. |
|
Yes, I have several Windows machines. I'll test, approve, then merge this PR. |
|
The user who reported this issue says that this fix solves the problem on Windows: ESCOMP/CTSM#362 (comment) |
|
Thanks for the update. I could never get it to fail on my Windows machine. |
fischer-ncar
approved these changes
Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix svn URLs on Windows
User interface changes?: No
Fixes: #166
Testing:
test removed: none
unit tests: pass
system tests: pass
manual testing: tested obtaining CESM release-cesm2.1.3 on my Mac