Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install git and ssh before checking out code on CircleCI #1601

Merged
merged 2 commits into from
May 24, 2022

Conversation

bouweandela
Copy link
Member

@bouweandela bouweandela commented May 23, 2022

Description

Closes #1600

I already uploaded a new docker container esmvalgroup/esmvalcore:development built from docker/Dockerfile.dev in this pull request. Tests in this branch and in #1554 are working as expected again with the new container.


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #1601 (e6683b2) into main (9486f47) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1601   +/-   ##
=======================================
  Coverage   90.99%   90.99%           
=======================================
  Files         201      201           
  Lines       10676    10676           
=======================================
  Hits         9715     9715           
  Misses        961      961           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9486f47...e6683b2. Read the comment docs.

@bouweandela bouweandela mentioned this pull request May 23, 2022
10 tasks
Copy link
Contributor

@schlunma schlunma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are running again in #1554, thanks @bouweandela for the quick fix! 🎉

@valeriupredoi please merge if you are also fine with these changes.

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch @bouweandela 🍺

@valeriupredoi valeriupredoi merged commit be6f654 into main May 24, 2022
@valeriupredoi valeriupredoi deleted the install-git-ssh branch May 24, 2022 10:54
@sloosvel sloosvel added this to the v2.6.0 milestone Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests are failing now because somehow the test_data_path fixture seems to point to the wrong directory.
4 participants