Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalized mask: use any given dataset cube to construct a mask to be applied to all other dataset cubes #1803

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented Nov 17, 2022

Description

Closes #1804

Link to documentation: to be added


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@valeriupredoi valeriupredoi added enhancement New feature or request preprocessor Related to the preprocessor labels Nov 17, 2022
@valeriupredoi valeriupredoi changed the title Generalized mask: use any given dataset cube to construct a mask to be applied to all dataset cubes Generalized mask: use any given dataset cube to construct a mask to be applied to all other dataset cubes Nov 17, 2022
@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (989839f) 93.74% compared to head (739cd61) 93.73%.

Files Patch % Lines
esmvalcore/preprocessor/_mask.py 81.81% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1803      +/-   ##
==========================================
- Coverage   93.74%   93.73%   -0.01%     
==========================================
  Files         238      238              
  Lines       13153    13164      +11     
==========================================
+ Hits        12330    12339       +9     
- Misses        823      825       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@valeriupredoi valeriupredoi added this to the v2.12.0 milestone Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request preprocessor Related to the preprocessor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generalized mask: apply a mask built from a dataset to all other datasets
1 participant