Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve preprocessor output sorting code #2111

Merged
merged 1 commit into from
Jun 23, 2023

Conversation

bouweandela
Copy link
Member

@bouweandela bouweandela commented Jun 23, 2023

Description

Follow up on #2103. This reduces duplicate code and avoids a potential crash if for some reason recipe_dataset_index would not be set (which seems unlikely).


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #2111 (6c6a839) into main (26b50fa) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2111   +/-   ##
=======================================
  Coverage   93.09%   93.09%           
=======================================
  Files         237      237           
  Lines       12804    12806    +2     
=======================================
+ Hits        11920    11922    +2     
  Misses        884      884           
Impacted Files Coverage Δ
esmvalcore/preprocessor/__init__.py 95.23% <100.00%> (ø)
esmvalcore/preprocessor/_io.py 86.85% <100.00%> (+0.10%) ⬆️

@bouweandela bouweandela added the preprocessor Related to the preprocessor label Jun 23, 2023
@bouweandela bouweandela added this to the v2.9.0 milestone Jun 23, 2023
@bouweandela bouweandela marked this pull request as ready for review June 23, 2023 09:27
Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice and tidy 🍺

@valeriupredoi valeriupredoi merged commit 1101d36 into main Jun 23, 2023
@valeriupredoi valeriupredoi deleted the improve-preproc-output-sorting branch June 23, 2023 13:38
@bouweandela bouweandela removed this from the v2.9.0 milestone Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preprocessor Related to the preprocessor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants