Relax the pin on iris to allow the use of older versions for performance reasons #2122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2122 +/- ##
=======================================
Coverage 93.09% 93.09%
=======================================
Files 237 237
Lines 12794 12794
=======================================
Hits 11910 11910
Misses 884 884 |
|
if you don't relax it in environment.yml as well it will be most of the times forced to 3.6+ and some users won't know how to downgrade it in their envs, bud 👍 |
|
If they ask in an issue we can explain it. This PR is just to allow those who really want it to use the older version, the default should be to use the latest version. |
|
OKi, sounds like a plan - I'll approve then |
valeriupredoi
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During testing for the v2.9.0 release of ESMValTool, we noticed that the latest versions of iris are considerably less performant with the Dask default scheduler. Therefore it would be good to allow using older versions of iris, even if these do not support the distributed scheduler. Note that a new installation will still default to the latest version of iris, so this is only for users who really want to use the older version.
See discussion in ESMValGroup/ESMValTool#3239 (comment)
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: