Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add merge instructions to release instructions #2131

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

zklaus
Copy link

@zklaus zklaus commented Jul 12, 2023

Description

Closes #2133

Link to documentation: https://esmvaltool--2131.org.readthedocs.build/projects/ESMValCore/en/2131/contributing.html#mark-the-release-in-the-main-branch


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #2131 (39e6f5d) into main (a6639a7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2131   +/-   ##
=======================================
  Coverage   93.09%   93.09%           
=======================================
  Files         237      237           
  Lines       12795    12795           
=======================================
  Hits        11911    11911           
  Misses        884      884           

@zklaus zklaus marked this pull request as ready for review July 12, 2023 14:00
@remi-kazeroni remi-kazeroni added documentation Improvements or additions to documentation release labels Jul 13, 2023
Copy link
Contributor

@remi-kazeroni remi-kazeroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, @zklaus! That is nicely written and explained 👍

Once that is merged, we should add the same documentation for the Tool here.

@schlunma, @valeriupredoi - could one of you do a final check and merge, please?

@remi-kazeroni remi-kazeroni added this to the v2.10.0 milestone Jul 13, 2023
Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice indeed, cheers, chaps 🍺

@valeriupredoi valeriupredoi merged commit 2de1a2a into main Jul 13, 2023
3 checks passed
@valeriupredoi valeriupredoi deleted the update-release-docs branch July 13, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve "Making a release" documentation
3 participants