Fixing missing height 2m coordinates in GFDL-CM4 and KIOST-ESM

[Karen-A-Garcia]

This is a follow up to issues #2293 and #2295. This is all using daily resolution CMIP6 data. In GFDL-CM4 in historical experiment tasmax, tasmin, sfcWind, and hurs are missing the 2m height coordinate. In Kiost-esm tasmin and tasmax has height issues. I just added quick fixes for those and tests for them. This is similar to what I did in pull request #2263.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f515169) 93.61% compared to head (97bb450) 93.70%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2294      +/-   ##
==========================================
+ Coverage   93.61%   93.70%   +0.09%     
==========================================
  Files         238      238              
  Lines       13113    13115       +2     
==========================================
+ Hits        12276    12290      +14     
+ Misses        837      825      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[valeriupredoi]

hi @Karen-A-Garcia happy new year and many thanks for the fixes and PR! I fixed the conflict in the test module, and will merge after them tests pass. A couple small pointers: when you import classes or functions from module, it's best practice to import them all in one line, rather than eg from moduleA import class1 / from moduleA import class2 do from moduleA import (class1, class2, ). Also, once you see merge conflicts, it's always good to, given you got time, fix them, or if the conflicts are something you don't really know how to fix, ask for help. One last thing - please work on branches that have different names for different things, it's very confusing (and sometimes dangerous) to recycle branch names (once they've been merged and deleted). Cheers 🍺

[valeriupredoi]

great, cheers! Nevermind my rant about imports (above) - saw this was due to the age of the branch, rather than of your own making 😁

[Karen-A-Garcia]

Still good advice! Thanks @valeriupredoi