Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmip6 gfdl_cm4: fix tas height fix to work for concatenated scenarios #2332

Merged
merged 2 commits into from
Feb 16, 2024

Conversation

mwjury
Copy link
Contributor

@mwjury mwjury commented Feb 12, 2024

In its current form the fix for correcting the height in TAS of GFDL-CM4 fails when concatenating the historical with ssp experiments with:

ValueError: Can not concatenate cubes: failed to concatenate into a single cube.
  Scalar coordinates values or metadata differ: height != height

This is due to:

  • the height coord being missing in the historical experiment, and being added by the current fix:
    	double height ;
            height:units = "m" ;
            height:standard_name = "height" ;
            height:long_name = "height" ;
            height:positive = "up" ;
  • the height coord in the scenarios being differently defined than the one added by the current fix
        double height ;
            height:long_name = "height" ;
            height:units = "m" ;
            height:missing_value = 1.e+20 ;
            height:_FillValue = 1.e+20 ;
            height:cell_methods = "time: point" ;
            height:axis = "Z" ;
            height:positive = "up" ;
            height:standard_name = "height" ;
            height:description = "~2 m standard surface air temperature and surface humidity  height" ;

However, the error is raised solely due to:

height:description = "~2 m standard surface air temperature and surface humidity height" ;

@mwjury mwjury assigned mwjury and unassigned mwjury Feb 12, 2024
@mwjury mwjury added the fix for dataset Related to dataset-specific fix files label Feb 12, 2024
@mwjury mwjury changed the title fix for dataset: cmip6 gfdl_cm4, fix tas height fix to work for concatenated scenarios cmip6 gfdl_cm4: fix tas height fix to work for concatenated scenarios Feb 12, 2024
Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3f610e7) 94.07% compared to head (13899bd) 94.07%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2332   +/-   ##
=======================================
  Coverage   94.07%   94.07%           
=======================================
  Files         240      240           
  Lines       13306    13306           
=======================================
  Hits        12517    12517           
  Misses        789      789           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

many thanks @mwjury 🍺

@valeriupredoi
Copy link
Contributor

though a slightly less destructive approach would be to check if that description attr exists, and add it with the said value - but am not 100% sure 1. how useful that is, and 2. if that will change in future data iterations and that'll break iris again 👍

@valeriupredoi valeriupredoi merged commit d936e4e into main Feb 16, 2024
5 checks passed
@valeriupredoi valeriupredoi deleted the gfdl_cm4_tas_fix branch February 16, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix for dataset Related to dataset-specific fix files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants