Optimize documentation about Earth mover distance in distance_metric preprocessor #2423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2423 +/- ##
=======================================
Coverage 94.83% 94.83%
=======================================
Files 251 251
Lines 14191 14191
=======================================
Hits 13458 13458
Misses 733 733 ☔ View full report in Codecov by Sentry. |
valeriupredoi
approved these changes
May 21, 2024
|
Maybe this needs a review from someone who understands? |
|
as inspired as my comment was, I think Mr CAT is unavailable for a review, anyone else that's not busy building the new ECMWF building? 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The old docs are slightly misleading.
Link to documentation: https://esmvaltool--2423.org.readthedocs.build/projects/ESMValCore/en/2423/recipe/preprocessor.html#distance-metric
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: