Fix bug in _rechunk_aux_factory_dependencies
#2428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehogan
changed the title
_rechunk_aux_factory_dependencies
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2428 +/- ##
=======================================
Coverage 94.51% 94.51%
=======================================
Files 246 246
Lines 14023 14023
=======================================
Hits 13254 13254
Misses 769 769 ☔ View full report in Codecov by Sentry. |
ehogan
added
bug
|
Cheers @ehogan 🍺 I'd review this myself, but I'd not be 100% confident with my review, best bod to review it is @bouweandela |
|
Brill, cheers, both 🍺 |
ehogan
commented
May 22, 2024
Comment on lines
-1165
to
+1155
| if coord_dims is not None: | ||
| if coord_dims: |
There was a problem hiding this comment.
I did want to mention that this was the actual change I made; all the other changes were introduced by the pre-commit hooks 😊
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #2427
Link to documentation:
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: