Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid copying input data in CMIP6 CESM2 air pressure level fixes #2454

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

bouweandela
Copy link
Member

Description

Use ncdata to fix files in-memory instead of copies on disk.

Related to #2129 and #674


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@bouweandela bouweandela mentioned this pull request Jun 10, 2024
62 tasks
@valeriupredoi
Copy link
Contributor

very cool @bouweandela 👏 Always nice to see data transfer optimizations, hope you don't mind me turning on the GA see if any issues for older Pythons - I took a look at the failed tests - couple of them due to mocks not called (easy fix) but one fails due to what looks to be a reversal of the lev bounds, can prob fix that for you here, if you don't have time 🍺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants