Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly cast to str a few cube and cubes instances in _io.py #2526

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Explicitly cast to str a few cube and cubes instances in _io.py #2526

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
65617ec
plop a few str
valeriupredoi Sep 17, 2024
f905f39
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Sep 17, 2024
5a1cda0
Revert "[pre-commit.ci] auto fixes from pre-commit.com hooks"
valeriupredoi Sep 17, 2024
7196f16
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Sep 17, 2024
294d17f
Revert "[pre-commit.ci] auto fixes from pre-commit.com hooks"
valeriupredoi Sep 17, 2024
4ef0c8f
Merge branch 'main' into plop_str_io
valeriupredoi Sep 17, 2024
327e312
Merge branch 'main' into plop_str_io
valeriupredoi Sep 20, 2024
e5c4d01
Merge branch 'main' into plop_str_io
valeriupredoi Sep 26, 2024
4e18994
Merge branch 'main' into plop_str_io
valeriupredoi Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions esmvalcore/preprocessor/_io.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,18 +457,19 @@ def save(
logger.debug(
"Not saving cubes %s to %s to avoid data loss. "
"The cube is probably unchanged.",
cubes,
str(cubes),
filename,
)
return filename

for cube in cubes:
logger.debug(
"Saving cube:\n%s\nwith %s data to %s",
cube,
str(cube),
"lazy" if cube.has_lazy_data() else "realized",
filename,
)

if optimize_access:
cube = cubes[0]
if optimize_access == "map":
Expand Down