Use pyproject.toml instead of setup.py/setup.cfg #2540
+166
−280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2540 +/- ##
==========================================
- Coverage 94.90% 94.64% -0.26%
==========================================
Files 251 251
Lines 14295 14295
==========================================
- Hits 13566 13530 -36
- Misses 729 765 +36 ☔ View full report in Codecov by Sentry. |
| pragma: no cover | ||
| if __name__ == .__main__.: | ||
| if TYPE_CHECKING: | ||
|
|
||
| [pycodestyle] |
There was a problem hiding this comment.
love the outcome of this issue, that was proposing support for pyproject.toml 🤣 PyCQA/pycodestyle#813
There was a problem hiding this comment.
We should be able to drop pycodestyle as soon as we're using ruff for linting too.
bouweandela
force-pushed
the
pyproject-toml
branch
from
f25c4f1
to
8e922f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use pyproject.toml instead of setup.py/setup.cfg, as this is the modern way of doing things.
Also added some improvements suggested by https://learn.scientific-python.org/development/guides/repo-review/?repo=esmvalgroup%2Fesmvalcore&branch=pyproject-toml
Link to documentation: https://esmvaltool--2540.org.readthedocs.build/projects/ESMValCore/en/2540/contributing.html
Related to ESMValGroup/ESMValTool#3584
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: