Free esmpy of >=8.6.0 pin and pin iris-grib >=0.20.0
#2542
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2542 +/- ##
=======================================
Coverage 94.90% 94.90%
=======================================
Files 251 251
Lines 14295 14295
=======================================
Hits 13566 13566
Misses 729 729 ☔ View full report in Codecov by Sentry. |
|
OK @schlunma - you should be fine with an unpinned esmf/esmpy and iris-grib>=0.20.0 - even NCL installs fine (...) but if we want to build a package with any Python <3.12 and NCL then we'd have to pin importlib_metadata <8 as per ESMValGroup/ESMValTool#3700 - we did that for ESMValTool in the last release, so it's no biggie. TL;DR if you happy you can merge this 🍺 |
|
(...) = ncl build h7cb714c_54 which the latest build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #2535
Long story short:
iris-gribneeds be pinned due to Add support for native ERA5 data in GRIB format #2178nclhas a hard pinesmf<8.6.0so whatevernclgets installed foresmf/esmpy>=8.6.0is about two years old (still 6.6.2 but a very old build, that did not have the pin in)esmf/esmpy<8.6.0ie8.4.2as per Is the fix from PR 353 compatible with esmpy<8.6.0 as well? SciTools/iris-esmf-regrid#415Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: