Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmorizer for NOAA-CIRES-20CR v3 reanalysis (clt, clwvi, hus, prw, rlut, rlutcs, rsut, rsutcs) #3137

Merged
merged 9 commits into from
Aug 14, 2023

Conversation

LisaBock
Copy link
Contributor

@LisaBock LisaBock commented Mar 28, 2023

Description

In this PR we add a downloader and formatter for the NOAA-CIRES-20CR v3 dataset. Therefore we add a 'v2' to the already existing cmorizer of NOAA-CIRES-20CR.

Related to #2851


Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

New or updated data reformatting script

@LisaBock LisaBock changed the title Add cmorizer for NOAA-CIRES-20CR v3 Cmorizer for NOAA-CIRES-20CR v3 reanalysis Mar 28, 2023
Copy link
Contributor

@axel-lauer axel-lauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the downloading and formatting scripts for NOAA-CIRES-20CR-V3 and also for NOAA-CIRES-20CR-V2. The CMORized output looks good. The changes to the documentation and the references also look good.

Copy link
Contributor

@remi-kazeroni remi-kazeroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, @LisaBock! The code looks good and all works fine: downloaders, formatters, recipe_check_obs 👍
The data are now in our common directories (RAWOBS, OBS) at DKRZ. The handling of both dataset versions looks fine to me. The remaining codacy issues can be ignored. Just left a tiny suggestion but this is ready to be merged 👍

esmvaltool/recipes/examples/recipe_check_obs.yml Outdated Show resolved Hide resolved
@remi-kazeroni remi-kazeroni added this to the v2.10.0 milestone Aug 14, 2023
@remi-kazeroni remi-kazeroni changed the title Cmorizer for NOAA-CIRES-20CR v3 reanalysis Cmorizer for NOAA-CIRES-20CR v3 reanalysis (clt, clwvi, hus, prw, rlut, rlutcs, rsut, rsutcs) Aug 14, 2023
Co-authored-by: Rémi Kazeroni <[email protected]>
@remi-kazeroni remi-kazeroni merged commit fd2bee7 into main Aug 14, 2023
2 of 3 checks passed
@remi-kazeroni remi-kazeroni deleted the cmorize_noaa_cires_20cr_v3 branch August 14, 2023 14:54
ehogan added a commit that referenced this pull request Aug 30, 2023
…_RTW

* recipe_test_workflow_prototype: (237 commits)
  Add version to dataset in python example recipe to avoid "Unknown file format" issue on JASMIN (#3322)
  CMORizer for NASA MERRA reanalysis (#3039)
  Add `OBS-maintainers` team to documentation on OBS data maintenance and CMORizer reviews (#3335)
  Fixed provenance tracking for NCL multipanel PNGs (#3332)
  Cmorizer for NOAA-CIRES-20CR v3 reanalysis (clt, clwvi, hus, prw, rlut, rlutcs, rsut, rsutcs) (#3137)
  [Condalock] Update Linux condalock file (#3321)
  Slight refactoring of diag `galytska23/select_variables_for_tigramite.py` for generality and portability (for Changelog v2.10: authors: @valeriupredoi and @egalytska) (#3298)
  Removed recipe_carvalhais14nat from list of broken recipes (#3319)
  add Romain Beucher to CITATION as contributor (#3318)
  update `mamba` version in readthedocs configuration docs builds (#3310)
  [Github Actions] Compress all bash shell setters into one default option per workflow (#3315)
  [condalock] update conda lock creation Github Action workflow and ship updated (bot-generated) conda-lock file (#3307)
  Allow NCL unit conversion `kg s-1` -> `GtC y-1` (#3300)
  Add list of failing recipes for v2.9.0 release (#3294)
  Update diag_shapeselect.py to work with shapely v2 (#3283)
  Update release schedule after release of v2.9.0 (#3289)
  Add merge instructions to release instructions (#3292)
  Made sklearn test backwards-compatible with sklearn < 1.3 (#3285)
  Add release notes for v2.9 (#3266)
  Add release notes for v2.9 (#3266)
  ...
jvegreg pushed a commit that referenced this pull request Jan 14, 2024
…t, rlutcs, rsut, rsutcs) (#3137)

Co-authored-by: Rémi Kazeroni <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants