Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EX-16373 - PrebidJS Adapter #1

Merged
merged 45 commits into from
Mar 14, 2024
Merged

EX-16373 - PrebidJS Adapter #1

merged 45 commits into from
Mar 14, 2024

Conversation

giuseppe-exads
Copy link

The main file of this feature is modules/exadsBidAdapter.js.

Copy link

@danielapereira11 danielapereira11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review of the .md files in terms of general structure and specific consistency changes that I think need addressing.

modules/exadsBidAdapter.md Show resolved Hide resolved
modules/exadsBidAdapter.md Outdated Show resolved Hide resolved
modules/exadsBidAdapter.md Outdated Show resolved Hide resolved
modules/exadsBidAdapter.md Outdated Show resolved Hide resolved
modules/exadsBidAdapter.md Show resolved Hide resolved
modules/exadsBidAdapter.md Outdated Show resolved Hide resolved
exads/doc/README.md Outdated Show resolved Hide resolved
exads/doc/README.md Outdated Show resolved Hide resolved
exads/doc/README.md Outdated Show resolved Hide resolved
exads/doc/README.md Outdated Show resolved Hide resolved
exads/examples/prebidJS-client-RTB-InStreamVideo.html Outdated Show resolved Hide resolved
exads/examples/prebidJS-client-RTB-InStreamVideo.html Outdated Show resolved Hide resolved
exads/examples/prebidJS-client-RTB-InStreamVideo.html Outdated Show resolved Hide resolved
exads/examples/prebidJS-client-RTB-InStreamVideo.html Outdated Show resolved Hide resolved
exads/examples/prebidJS-client-RTB-InStreamVideo.html Outdated Show resolved Hide resolved
test/spec/modules/exadsBidAdapter_spec.js Outdated Show resolved Hide resolved
test/spec/modules/exadsBidAdapter_spec.js Outdated Show resolved Hide resolved
test/spec/modules/exadsBidAdapter_spec.js Show resolved Hide resolved
test/spec/modules/exadsBidAdapter_spec.js Outdated Show resolved Hide resolved
test/spec/modules/exadsBidAdapter_spec.js Outdated Show resolved Hide resolved
modules/exadsBidAdapter.md Outdated Show resolved Hide resolved
modules/exadsBidAdapter.md Outdated Show resolved Hide resolved
modules/exadsBidAdapter.md Outdated Show resolved Hide resolved
modules/exadsBidAdapter.md Outdated Show resolved Hide resolved
modules/exadsBidAdapter.md Outdated Show resolved Hide resolved
modules/exadsBidAdapter.md Outdated Show resolved Hide resolved
modules/exadsBidAdapter.md Outdated Show resolved Hide resolved
exads/examples/prebidJS-client-RTB-banner.html Outdated Show resolved Hide resolved
exads/examples/prebidJS-client-RTB-native.html Outdated Show resolved Hide resolved
modules/exadsBidAdapter.js Outdated Show resolved Hide resolved
Copy link

@danielapereira11 danielapereira11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

into » in

exads/doc/README.md Outdated Show resolved Hide resolved
exads/doc/README.md Outdated Show resolved Hide resolved
exads/doc/README.md Outdated Show resolved Hide resolved
Copy link
Member

@broucz broucz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job on the implementation but some minor points should be addressed before submitting our PR to Prebid.

exads/doc/README.md Outdated Show resolved Hide resolved
exads/doc/README.md Outdated Show resolved Hide resolved
modules/exadsBidAdapter.js Outdated Show resolved Hide resolved
modules/exadsBidAdapter.js Outdated Show resolved Hide resolved
modules/exadsBidAdapter.js Outdated Show resolved Hide resolved
modules/exadsBidAdapter.js Outdated Show resolved Hide resolved
modules/exadsBidAdapter.js Outdated Show resolved Hide resolved
modules/exadsBidAdapter.js Show resolved Hide resolved
modules/exadsBidAdapter.js Outdated Show resolved Hide resolved
modules/exadsBidAdapter.js Outdated Show resolved Hide resolved
tfoliveira pushed a commit that referenced this pull request Jan 30, 2024
…erter (prebid#10177)

* ET-1691: Pulsepoint Analytics adapter for Prebid. (#1)

* ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter

* ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter

* ET-1691: cleanup

* ET-1691: minor

* ET-1691: revert package.json change

* Adding bidRequest to bidFactory.createBid method as per prebid#509

* ET-1765: Adding support for additional params in PulsePoint adapter (#2)

* ET-1850: Fixing prebid#866

* Minor fix

* Adding mandatory parameters to Bid

* Switching to ortbConverter

* updating docs

---------

Co-authored-by: Eugene Rachitskiy <[email protected]>
modules/exadsBidAdapter.js Show resolved Hide resolved
exads/doc/README.md Outdated Show resolved Hide resolved
tfoliveira pushed a commit that referenced this pull request Mar 6, 2024
* Kimberlite bid adapter (#1)

* initial: bid adapter

* styling

* Fix: lint (#2)

* Fix: lint (#4)

* review fixes (prebid#6)

* Change: filling request.ext.prebid section (prebid#7)

---------

Co-authored-by: Oleg <[email protected]>
tfoliveira pushed a commit that referenced this pull request Mar 6, 2024
* PE-87: Implement Prebid Adapter (#1)

* PE-87: implement BT Bid Adapter

* PE-87: rework adapter to use ortbConverter lib, make requested changes

* PE-87: update imports

* PE-110: Add user sync logic to the Prebid Adapter (#3)

* PE-110: add user sync logic

* PE-110: update userSync url

* PE-110: check if iframe is enabled before setting params

* PE-111: BT Prebid Adapter can request AA ads or regular ads (#2)

* PE-120: Send Prebid Bidder info to BT Server (#4)

* PE-120: add btBidderCode to the bid object

* PE-120: use single quotes for logs string

* PE-123: Add More Metadata in site.ext.blockthrough (prebid#5)

* PE-123: send additional meta data

* PE-123: send auctionID under imp.ext.prebid.blockthrough

* PE-123: use ortb2 config to set site.ext params

* PE-123: sent auctionId in ext.prebid.blockthrough.auctionID

* PE-123: update logs for bidderConfig setup

* PE-000: check if blockthrough is defined (prebid#6)

* PE-87: remove BT specific logic (prebid#7)

* Implement Blockthrough Prebid Adapter

* PE-87: Implement Prebid Adapter - misc fixes (prebid#9)

* PE-87: rename test file, add bidder config

* PE-87: increase ttl

* PE-000: fix test

* BP-74: Change the way we enable debug (prebid#10)

* BP-79: Send GPID as a part of `imp[].ext` (prebid#11)

* BP-79: send gpid in imp.ext

* BP-79: add optional operator

* BP-90: Update Cookie Sync Logic (prebid#12)

* BP-90: pass bidder to cookie sync

* BP-90: update sync logic, fix typo

* BP-90: use const for syncs variable

* BP-55: Re-add endpoint URLs (prebid#13)

* BP-91: Add prebid JS version to auction request (prebid#14)
@tfoliveira tfoliveira merged commit ab61372 into master Mar 14, 2024
@tfoliveira tfoliveira deleted the EX-16373 branch March 14, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants