Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pit scouting #30

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

Pit scouting #30

wants to merge 23 commits into from

Conversation

alaninnovates
Copy link
Member

@alaninnovates alaninnovates commented Jan 13, 2024

Adds pit scouting

To test and merge:
SearchMain.tsx should be overrided with the contents of commit 46591ad
ReportsForTeam.tsx is based off of commit 46591ad, no changes should be needed

Before merging, the "Camera Test" tab should be removed from the navbar. The pit scouting screen should eventually be accessed through the plus button navigation from app-redesign. Before app-redesign is merged, the code can just exist without any way to access it.

Additional notes:
Because of the new pit scout form field added to each competition, fkeys need to be provided to hint supabase as to where it should query. As an example, in ScoutReports.ts, querying a form structure from a competition & match is done as such:matches(competitions(forms!competitions_form_id_fkey(form_structure)))

@alaninnovates
Copy link
Member Author

I will need to add the supabase migrations later, don't merge yet

@alaninnovates
Copy link
Member Author

Minor oversight that should be resolved before merge: the data tab currently does not display pit scout reports, only normal scout reports. We can use a top tab navigator of some sorts to split it between the two types of reports, as there may be a lot.

@alaninnovates
Copy link
Member Author

Because of the new notes feature, a top tab navigator will be pretty much required, as this lets us put scout reports, pit scout reports, and notes in the same place.

Copy link
Member

@gaborszita gaborszita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I ran it on android:

  1. First when I ran it I got this error:
ERROR  Camera.onError(unknown/unknown): [unknown/unknown] validateClientPermissionsLocked:1547: Caller "com.eaglescout" (PID 10502, UID 30585) cannot open camera "0" without camera permission [unknown/unknown: [unknown/unknown] validateClientPermissionsLocked:1547: Caller "com.eaglescout" (PID 10502, UID 30585) cannot open camera "0" without camera permission]

I granted access to the camera manually in the settings. It should prompt for access instead of requiring the user to go in the settings.
Also, if it does not have access, it should handle it and display a message to the user. Right now it just is just stuck on a black camera screen.

  1. After granting permission to the camera, when I ran it on the Android emulator, it worked. But when I ran it on my phone it just displays a black camera screen and when I click the shutter I get this error:
WARN  Possible Unhandled Promise Rejection (id: 1):
capture/photo-not-enabled: [capture/photo-not-enabled] Photo capture is disabled! Pass `photo={true}` to enable photo capture.
[capture/photo-not-enabled]: [capture/photo-not-enabled] Photo capture is disabled! Pass `photo={true}` to enable photo capture.

This is the black camera screen:
Screenshot_20240129_170731_EagleScout

  1. There should be a back or cancel button or something on the camera screen

@gaborszita gaborszita marked this pull request as draft January 31, 2024 18:56
Copy link
Member

@gaborszita gaborszita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaborszita
Copy link
Member

Camers is OK

@alaninnovates alaninnovates marked this pull request as ready for review February 28, 2024 19:58
});
console.log('hi');
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uhhh we should probably remove this log

@alaninnovates alaninnovates dismissed gaborszita’s stale review February 29, 2024 23:35

idk how to resolve the review

@gaborszita gaborszita self-requested a review March 6, 2024 20:36
@Versus7
Copy link
Member

Versus7 commented Apr 11, 2024

What's the latest on this? @gaborszita @alaninnovates

@gaborszita
Copy link
Member

Need more testing on it, mainly the auto push to db thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants