Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrub cassettes #253

Merged
merged 3 commits into from
Jun 2, 2022
Merged

Scrub cassettes #253

merged 3 commits into from
Jun 2, 2022

Conversation

Justintime50
Copy link
Member

@Justintime50 Justintime50 commented Jun 1, 2022

Description

This PR scrubs sensitive data from cassette files.

Cassette responses are also now decompressed and decoded so they can be inspected visually. I've filed Netflix/pollyjs#463 with Pollyjs in hopes they support this feature officially as all other VCR solutions do.

There are a couple cassettes that can no longer match properly (update user & carrier account + insure a shipment). This appears to be a chronic issue across libs though and so we'll revisit the few skipped tests here soon.

Testing

  • Re-recorded all cassettes so data would be scrubbed and ensured recording/playback worked with decoded responses

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@Justintime50 Justintime50 marked this pull request as ready for review June 1, 2022 22:18
Copy link
Member

@nwithan8 nwithan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not seeing the cassette encoding file you mention in the Pollyjs comment. Did it get included?

@Justintime50
Copy link
Member Author

I'm not seeing the cassette encoding file you mention in the Pollyjs comment. Did it get included?

Yep, it's in the helpers directory in the test folder.

@nwithan8 nwithan8 self-requested a review June 2, 2022 16:35
@nwithan8 nwithan8 dismissed their stale review June 2, 2022 16:36

Addressed

@Justintime50 Justintime50 merged commit 58520d6 into master Jun 2, 2022
@Justintime50 Justintime50 deleted the scrub_cassettes branch June 2, 2022 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants