Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Platform separation #2781

Merged
merged 8 commits into from
May 28, 2022
Merged

Platform separation #2781

merged 8 commits into from
May 28, 2022

Conversation

carstene1ns
Copy link
Member

Tried to clean up player main code base.

@Ghabry
Copy link
Member

Ghabry commented May 9, 2022

only quickly scrolled through it: I like this approach, especially the early setup with the individual mains.

src/player.h Show resolved Hide resolved
@Ghabry
Copy link
Member

Ghabry commented May 27, 2022

this looks good so far

@carstene1ns carstene1ns marked this pull request as ready for review May 27, 2022 22:13
@carstene1ns carstene1ns changed the title RFC: platform separation Platform separation May 27, 2022
src/platform/sdl/sdl_ui.cpp Outdated Show resolved Hide resolved
src/player.h Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
@carstene1ns carstene1ns force-pushed the cleanup/platforms branch 3 times, most recently from 3043fd1 to 399ccee Compare May 28, 2022 01:31
@carstene1ns
Copy link
Member Author

ready

@carstene1ns carstene1ns requested a review from Ghabry May 28, 2022 15:04
Copy link
Member

@Ghabry Ghabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. A totally reasonable refactor finally possible after getting rid of all the Makefiles.
Will also make adding new ports a much cleaner approach 👍

@Ghabry Ghabry added this to the 0.7.1 milestone May 28, 2022
@Ghabry Ghabry merged commit 3842fd3 into EasyRPG:master May 28, 2022
@carstene1ns carstene1ns deleted the cleanup/platforms branch May 29, 2022 13:51
@Ghabry Ghabry added the Building label Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants