Add missing <cstdint> includes #2881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some files use various fixed-size types (uint8_t, uint32_t, etc.), which are declared in stdint.h / cstdint - without including this header file. With GCC13, the inter-header relationships have changed and stdint is no longer included transitively, leading to compilation errors. This commit adds explicit #includes whenever necessary.
|
Jenkins: Test this please Thanks! I setup a Fedora 38 VM loally to ensure the remaining PRs do not break the upcoming release when compiling against g++13. :) |
Ghabry
approved these changes
Jan 24, 2023
fdelapena
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some files use various fixed-size types (
uint8_t,uint32_t, etc.), which are declared instdint.h/cstdint- without including this header file. With GCC13, the inter-header relationships have changed and stdint is no longer included transitively, leading to compilation errors. This commit adds explicit#includestatements whenever necessary.