This repository has been archived by the owner on Oct 15, 2021. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 7
Update to create a BZ migration script making use of existing code #139
Draft
autumnfound
wants to merge
6
commits into
EclipseFdn:master
Choose a base branch
from
autumnfound:malowe/master/bz-mig
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Items left todo:
|
Linting still fails due to an error that is external to changes made for GL mig script. Will fix as separate PR |
Signed-off-by: Martin Lowe <[email protected]>
Signed-off-by: Martin Lowe <[email protected]>
Signed-off-by: Martin Lowe <[email protected]>
Signed-off-by: Martin Lowe <[email protected]>
Signed-off-by: Martin Lowe <[email protected]>
autumnfound
force-pushed
the
malowe/master/bz-mig
branch
from
January 25, 2021 18:00
076af76
to
eefd5a5
Compare
Signed-off-by: Martin Lowe <[email protected]>
I've validated BZ issue closing in my local environment! This should be ready to go. |
autumnfound
requested review from
chrisguindon,
agafgfafa,
ericpoirier and
flora8984461
February 26, 2021 16:38
@autumnfound what should we do with this? |
I'll be honest, I have no idea. For now, probably leave it? We may use it whenever GL gets around to fixing comments API |
chrisguindon
removed request for
ericpoirier,
chrisguindon,
agafgfafa and
flora8984461
April 23, 2021 19:51
@autumnfound +1 I removed us as reviewers and marked this as a draft for now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Martin Lowe [email protected]