Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unset "shop_cipher" from "Create Custom Brands" request #45

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

alvgalrus
Copy link
Contributor

@alvgalrus alvgalrus commented Sep 9, 2024

Hello, and thank you for the library!

When I tried to createCustomBrand($name), I got an error with the message shop_cipher is not allowed in this api. I see there's already a condition for that in the Client:

if (preg_match('/^\/product\/(\d{6})\/(global_products|files\/upload|images\/upload)/', $uri->getPath())
|| preg_match('/^\/(authorization|seller)\/(\d{6})\//', $uri->getPath())) {
unset($query['shop_cipher']);
}

This PR unsets shop_cipher when POST'ing to that endpoint. The GET one still needs it following the documentation:

Regards,
Álvaro

@nVuln nVuln merged commit 02780fa into EcomPHP:master Sep 9, 2024
7 checks passed
@nVuln
Copy link
Collaborator

nVuln commented Sep 9, 2024

I already merged and tagged new version to this PR
thanks for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants