Use the generalized get_pr_latencies for import stats #15
Conversation
|
OK, with 3c4ead3 there are only sub-second differences in what the latency is, as well as 5 PRs missing from the output relative to before. web-platform-tests/wpt#10445 and web-platform-tests/wpt#10543 are because of web-platform-tests/wpt#10572 (no tags) and will presumably be fixed by adding the tags. web-platform-tests/wpt#6559 and web-platform-tests/wpt#6845 are Chromium exports that should be excluded and do have a value in the web-platform-tests/wpt#6449 wasn't really an import, but looks like it from the merge commit. It looks like the last 3 remain only because the database is read back from disk and wouldn't be output by the script from scratch. This PR drops the caching, so that's OK. |
|
@Hexcles, post-land review appreciated for style, even if I'm confident I didn't regress the data now. |
|
|
||
| for entry in latencies: | ||
| pr = entry['pr'] | ||
| i = entry['event'] |
There was a problem hiding this comment.
I'm nitpicking here, but i is not a good variable name here (single-character variable names are more acceptable in lambdas, and i in particular is usually used for iterators).
There was a problem hiding this comment.
I know, import was the original name, that's a keyword, and I didn't know what to call it. Ideas?
From #10.
Fixes #4.