Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct attribute for read-properties #777

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Conversation

lupino3
Copy link
Member

@lupino3 lupino3 commented Sep 10, 2023

This was broken in version 1.1.1.

Fixes #774.

@codecov-commenter
Copy link

Codecov Report

Merging #777 (f32f1ff) into master (796fba9) will not change coverage.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #777   +/-   ##
=========================================
  Coverage     51.14%   51.14%           
  Complexity     1447     1447           
=========================================
  Files           249      249           
  Lines          9879     9879           
  Branches       1092     1092           
=========================================
  Hits           5053     5053           
  Misses         4507     4507           
  Partials        319      319           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 796fba9...f32f1ff. Read the comment docs.

@github-actions github-actions bot temporarily deployed to 777 September 10, 2023 17:12 Destroyed
@github-actions github-actions bot temporarily deployed to 777 September 19, 2023 16:10 Destroyed
@lupino3 lupino3 merged commit 9281ed7 into master Sep 19, 2023
10 checks passed
@lupino3 lupino3 deleted the fix-read-properties branch September 19, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PR pipeline does not upload the JAR sometimes
2 participants