Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SKLL to v3.2.0 #591

Merged
merged 3 commits into from
Jan 19, 2023
Merged

Update SKLL to v3.2.0 #591

merged 3 commits into from
Jan 19, 2023

Conversation

desilinguist
Copy link
Member

@desilinguist desilinguist commented Jan 19, 2023

  • Update SKLL dependency to v3.2.0
  • Replace deprecated scikit-learn method in modeler.py.
  • Update all SKLL models for tests.

@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Base: 93.20% // Head: 93.20% // No change to project coverage 👍

Coverage data is based on head (b1e2dd3) compared to base (5f9ca80).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #591   +/-   ##
=======================================
  Coverage   93.20%   93.20%           
=======================================
  Files          31       31           
  Lines        4549     4549           
=======================================
  Hits         4240     4240           
  Misses        309      309           
Impacted Files Coverage Δ
rsmtool/modeler.py 97.59% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@desilinguist desilinguist merged commit 92a2e20 into main Jan 19, 2023
@delete-merged-branch delete-merged-branch bot deleted the update-skll-models branch January 19, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants